Skip plugin entirely in production builds - #5

tests/vite-plugin.test.ts (3)

76-80: Duplicate apply assertion — consolidate into the plugin metadata describe block.

This test (and its twin at line 252) only asserts plugin.apply === "serve" — it's testing plugin metadata, not transform or transformIndexHtml behaviour. Having the same one-liner assertion in two different describe blocks adds noise without coverage benefit.

♻️ Suggested consolidation

Remove lines 76–80 and 252–256, and add a single test to the plugin metadata describe block:

 describe("plugin metadata", () => {
   test("has correct name", () => {
     const plugin = solidGrab();
     expect(plugin.name).toBe("solid-grab");
   });

   test("enforces pre", () => {
     const plugin = solidGrab();
     expect(plugin.enforce).toBe("pre");
   });
+
+  test("applies only during serve (skipped in production builds)", () => {
+    const plugin = solidGrab();
+    expect(plugin.apply).toBe("serve");
+  });
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/vite-plugin.test.ts` around lines 76 - 80, Remove the duplicate
one-line tests that only assert plugin.apply === "serve" (the test named "skips
in production mode (apply: serve)" and its twin) and instead add a single
assertion inside the existing "plugin metadata" describe block that checks the
plugin metadata once; locate the creation of the plugin via solidGrab() and
place expect(plugin.apply).toBe("serve") in that metadata block so metadata
checks are consolidated and the redundant tests are deleted.

---

6-21: mode parameter in createPlugin is now vestigial.

configResolved only reads config.root after the isDev removal. The command and mode fields injected into fakeConfig are passed to the hook but never consumed, making the mode parameter a no-op that could mislead future contributors into thinking production-mode behaviour can still be exercised through this helper.

♻️ Suggested simplification

 function createPlugin(
   options: Parameters<typeof solidGrab>[0] = {},
-  mode: "development" | "production" = "development"
 ): Plugin {
   const plugin = solidGrab(options);

-  const fakeConfig = {
-    root: "/project",
-    command: mode === "development" ? "serve" : "build",
-    mode,
-  } as ResolvedConfig;
+  const fakeConfig = { root: "/project" } as ResolvedConfig;

   (plugin as any).configResolved(fakeConfig);
   return plugin;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/vite-plugin.test.ts` around lines 6 - 21, The createPlugin helper has a
vestigial mode parameter and populates fakeConfig.command and fakeConfig.mode
which configResolved no longer consumes; remove the mode parameter from
createPlugin, simplify fakeConfig to only include root (e.g., { root: "/project"
} as ResolvedConfig), and update any test callers of createPlugin to the new
signature so they no longer pass or rely on the removed mode argument; keep the
call to (plugin as any).configResolved(fakeConfig) and the function name
createPlugin unchanged.

---

240-250: Test name "in dev mode" is a slight misnomer after the isDev removal.

The hook no longer has an internal dev-mode guard; it runs whenever Vite invokes it (which is only during serve, thanks to apply: "serve"). The name implies conditional dev-mode behaviour that no longer exists in the hook body.

-  test("returns tag descriptors in dev mode", () => {
+  test("returns tag descriptors when autoImport is enabled", () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/vite-plugin.test.ts` around lines 240 - 250, Rename the test to remove
the "in dev mode" wording since isDev was removed: update the test description
string in tests/vite-plugin.test.ts (the test that calls createPlugin() and
invokes (plugin as any).transformIndexHtml()) to something like "returns tag
descriptors" or "returns tag descriptors when invoked", keeping the rest of the
test body unchanged so the assertion targets (createPlugin, transformIndexHtml,
and the tag/attrs/injectTo expectations) remain the same.

Configuration used: defaults

Review profile: CHILL

Plan: Pro